[FFmpeg-devel] [PATCH] Limited timecode support for lavd/decklink

[Marton Balint]

On Sat, 26 May 2018, Jonathan Morley wrote:

> Attaching again from another mail client.

Thanks. There is one issue I found:

You are setting &ctx->video_st->metadata from the VideoInputFrameArrived 
callback. That runs in a separate thread from the main thread 
handling read_packet calls, and you can only invalidate 
video_st->metadata in the main thread. So I suggest to store the timecode 
string in a context variable, and do av_dict_set in 
ff_decklink_read_packet after avpacket_queue_get.

Regards,
Marton