[FFmpeg-devel] [PATCH] [V2] avcodec/qsvenc: add VDENC support for H264 and HEVC

[Fu, Linjie]

> -----Original Message----- 
> On Mon, Nov 05, 2018 at 09:50:13 +0800, Linjie Fu wrote:
> > It's an experimental function(like lowpower in vaapi) with
> 
> Should it be under "-strict experimental" then?
> 
> > module parameter(i915.enable_guc=2 for linux kerner version >= 4.16)
>                                                ^ kernel
> 
> > [V2]: modified the commit message and option comments, use
> AV_OPT_TYPE_BOOL
> > to replace AV_OPT_TYPE_INT.
> 
> This remark belongs below the "---" line, so it doesn't show up in the
> actual final commit.
> 
> > Signed-off-by: Linjie Fu <linjie.fu at intel.com>
> > ---
> 
> (Right here.)

Thanks, got it.

> > +    { "low_power", "enable low power mode (experimental, many
> limitations by mfx version, HW platform, BRC modes, etc.",
> OFFSET(qsv.low_power), AV_OPT_TYPE_BOOL, { .i64 =  0 }, 0, 1, VE},
>                                              ^ please also add a closing bracket
> > +++ b/libavcodec/qsvenc_hevc.c
> [...]
> > +    { "low_power", "enable low power mode (experimental, many
> limitations by mfx version, HW platform, BRC modes, etc.",
> OFFSET(qsv.low_power), AV_OPT_TYPE_BOOL, { .i64 =  0 },  0,  1, VE },
> Same here.
> 
> Moritz

Thanks for your review, and I'm so sorry for these mistakes.