[FFmpeg-devel] [PATCH] lavfi/vf_colorconstancy: add weighted_greyedge

Moritz Barsnick barsnick at gmx.net
Mon Oct 1 13:24:43 EEST 2018


> +The standard deviation of Gaussian blur to be applied on the scene. Must be
                                                         ^ to

> +The power applied to the weight map to emphasis heigher weights. Must be chosen
                                          ^ emphasize

> +The angular error threshold in degrees for stoping the algorithm. Must be chosen
                                              ^ stopping

> + * @cite
> + *  J. van de Weijer, Th. Gevers, and J. Geusebroek,
> + * ???Edge and corner detection by photometric quasi-invariants???.
      ^^^
You should fix the quotation marks here.

> - * @return 0 in case of success, a negative value corresponding to an
> - * AVERROR code in case of failure.
> + * @return 0.
>   */
> -static int filter_grey_edge(AVFilterContext *ctx, AVFrame *in)
> +static int filter_slice_weighted_grey_edge(AVFilterContext* ctx, void* arg, int jobnr, int nb_jobs)

If it only ever returns 0, you can probably make it void - unless it
will be expanded later to require a return code.

Moritz


More information about the ffmpeg-devel mailing list