[FFmpeg-devel] [PATCH 2/3] avformat/utils: Do not use "i" as a context pointer, "i" is normally the integer counter in loops

[Michael Niedermayer]

On Wed, Sep 26, 2018 at 07:15:36PM -0300, James Almer wrote:
> On 9/26/2018 7:00 PM, Michael Niedermayer wrote:
> > This avoids surprising developers. Its bad to surprise developers with
> > such unexpected things.
> > 
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavformat/utils.c | 42 +++++++++++++++++++++---------------------
> >  1 file changed, 21 insertions(+), 21 deletions(-)
> > 
> > diff --git a/libavformat/utils.c b/libavformat/utils.c
> > index 7e5783c14c..c1835b1ab5 100644
> > --- a/libavformat/utils.c
> > +++ b/libavformat/utils.c
> > @@ -3461,7 +3461,7 @@ static int extract_extradata_check(AVStream *st)
> >  
> >  static int extract_extradata_init(AVStream *st)
> >  {
> > -    AVStreamInternal *i = st->internal;
> > +    AVStreamInternal *avsti = st->internal;
> 
> How about sti instead? AVStream is usually set as st.

good idea, will change it

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181006/341cc67b/attachment.sig>