[FFmpeg-devel] swscale/x86/rgb2rgb : port shuffle2103 to external asm

[Michael Niedermayer]

On Tue, Oct 09, 2018 at 09:51:16PM +0200, Martin Vignali wrote:
> > > >
> > > > Keeping both MMX and MMXEXT seems a bit excessive. Ideally both would
> > > > be replaced with something more modern, but I'd at least drop the MMX
> > > > one.
> > > >
> > >
> > > This func already have SSSE3 version (AVX2 can be add easily, but doesn't
> > > find a command line where the speed is interesting in AVX2 (on my
> > > computer)).
> > > I can remove mmx, and only keep mmxext, or remove both (but seems like
> > not
> > > everyone is agree to remove mmx/mmxext, if SSxx version is available).
> > >
> >
> > If we don't want to drop both, then drop mmx and keep mmxext. Having
> > both serves no point in 2018, and is a nice artifact that shows how
> > old swscale really is.
> >
> > New patch in attach
> port only mmext to external asm
> Also fix, the number of xmm register (8 instead of 2)
> 
> Martin

>  rgb2rgb.c          |    4 +++
>  rgb2rgb_template.c |   63 -----------------------------------------------------
>  rgb_2_rgb.asm      |   63 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 67 insertions(+), 63 deletions(-)
> 1a741cd21d922f65a0944336768410404257b1fc  0001-swscale-x86-rgb2rgb-port-shuffle2103-to-external-asm.patch
> From 58ce1380d31cdc8fc80de6dec852bee919fb210d Mon Sep 17 00:00:00 2001
> From: Martin Vignali <martin.vignali at gmail.com>
> Date: Tue, 9 Oct 2018 21:44:09 +0200
> Subject: [PATCH] swscale/x86/rgb2rgb : port shuffle2103 to external asm  for
>  mmext version
> 
> and remove the inline asm version (mmx and mmxext)

porting code and removing code sounds like 2 seperate things, 
that should not be in the same patch

also if anyone wants to remove more mmx functions, be carefull please
so this doesnt break the code on a codepath that is rarely tested.

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Take away the freedom of one citizen and you will be jailed, take away
the freedom of all citizens and you will be congratulated by your peers
in Parliament.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181009/75901789/attachment.sig>