[FFmpeg-devel] [PATCH 1/3] lavc/h264: create AVFrame side data from H.264 timecodes

[Michael Niedermayer]

On Tue, Oct 09, 2018 at 02:32:02PM +0100, joshdk at ob-encoder.com wrote:
> From: Devin Heitmueller <dheitmueller at ltnglobal.com>
> 
> Create SMPTE ST 12-1 timecodes based on H.264 SEI picture timing
> info.
> 
> For framerates > 30 FPS, the field flag is used in conjunction with
> pairs of frames which contain the same frame timestamp in S12M.
> Ensure the field is properly set per the spec.
[...]

> diff --git a/libavutil/frame.h b/libavutil/frame.h
> index 9d57d6ce66..0061103894 100644
> --- a/libavutil/frame.h
> +++ b/libavutil/frame.h
> @@ -123,6 +123,12 @@ enum AVFrameSideDataType {
>       */
>      AV_FRAME_DATA_GOP_TIMECODE,
>  
> +    /**
> +     * Timecode which conforms to SMPTE ST 12-1.  The data is a uint32_t which
> +     * can be found described in libavutil/timecode.h.

Thats not good enough for public API, the user wont even know what part of
timecode.h describes it


> +     */
> +    AV_FRAME_DATA_S12M_TIMECODE,

this cannot be added into the middle of the enum, that would break ABI

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181010/89077fb7/attachment.sig>