[FFmpeg-devel] [PATCH] avdevice: Fix ioctl method signature for Android builds

[Carl Eugen Hoyos]

2018-10-22 18:40 GMT+02:00, Don Turner <donturner-at-google.com at ffmpeg.org>:
> When compiling avdevice for Android I received a compile error from
> libavdevice/v4l2.c.

I only get a warning here.

> Full details in the 2nd part of this answer:
> https://stackoverflow.com/questions/52896607/why-do-i-get-error-invalid-instruction-mnemonic-when-compiling-ffmpeg-for-and/52900973#52900973
>
> Patch below:
>
> diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c
> index 10a0ff0dd6..1b9c6e760b 100644
> --- a/libavdevice/v4l2.c
> +++ b/libavdevice/v4l2.c
> @@ -95,7 +95,11 @@ struct video_data {
>      int (*open_f)(const char *file, int oflag, ...);
>      int (*close_f)(int fd);
>      int (*dup_f)(int fd);
> +#ifdef __GLIBC__
>      int (*ioctl_f)(int fd, unsigned long int request, ...);
> +#else
> +    int (*ioctl_f)(int fd, int request, ...);
> +#endif

Is this better than checking for target-os "android"?

Carl Eugen