[FFmpeg-devel] [PATCH] avfilter: add bm3d filter

[Michael Niedermayer]

On Sat, May 12, 2018 at 01:54:49PM +0200, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  doc/filters.texi         |   86 ++++
>  libavfilter/Makefile     |    1 +
>  libavfilter/allfilters.c |    1 +
>  libavfilter/vf_bm3d.c    | 1077 ++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 1165 insertions(+)
>  create mode 100644 libavfilter/vf_bm3d.c
[...]
> +static void do_output16(BM3DContext *s, uint8_t *dst, int dst_linesize,
> +                        int plane, int nb_jobs)
> +{
> +    const int height = s->planeheight[plane];
> +    const int width = s->planewidth[plane];
> +    const int depth = s->depth;
> +    int i, j, k;
> +
> +    for (i = 0; i < height; i++) {
> +        for (j = 0; j < width; j++) {
> +            uint16_t *dstp = (uint16_t *)dst + i * dst_linesize / 2;
> +            float sum_den = 0.f;
> +            float sum_num = 0.f;
> +
> +            for (k = 0; k < nb_jobs; k++) {
> +                SliceContext *sc = &s->slices[k];
> +                float num = sc->num[i * width + j];
> +                float den = sc->den[i * width + j];
> +
> +                sum_num += num;
> +                sum_den += den;
> +            }
> +
> +            dstp[j] = av_clip_uintp2(sum_num / sum_den, depth);

fails to build
CC	libavfilter/vf_bm3d.o
In file included from src/libavutil/intmath.h:30:0,
                 from src/libavutil/common.h:106,
                 from src/libavutil/avutil.h:296,
                 from src/libavutil/avassert.h:31,
                 from src/libavfilter/vf_bm3d.c:35:
src/libavutil/arm/intmath.h: In function ‘do_output16’:
src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn’t match constraints [enabled by default]
src/libavutil/arm/intmath.h:77:5: error: impossible constraint in ‘asm’
src/libavfilter/vf_bm3d.c: In function ‘config_output’:
src/libavfilter/vf_bm3d.c:1006:21: warning: ‘ref’ may be used uninitialized in this function [-Wuninitialized]
make: *** [libavfilter/vf_bm3d.o] Error 1

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180913/40149be4/attachment.sig>