[FFmpeg-devel] [PATCH 1/4] avformat/matroskaenc: remove unnecessary additional codec tags

[Carl Eugen Hoyos]

> Am 21.09.2018 um 23:29 schrieb James Almer <jamrial at gmail.com>:
> 
> They are listed in riff.c already.
> 
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
> libavformat/matroskaenc.c | 3 ---
> 1 file changed, 3 deletions(-)
> 
> diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
> index a0e2f426f7..61efe2e3f8 100644
> --- a/libavformat/matroskaenc.c
> +++ b/libavformat/matroskaenc.c
> @@ -2735,7 +2735,6 @@ static int mkv_check_bitstream(struct AVFormatContext *s, const AVPacket *pkt)
> 
> static const AVCodecTag additional_audio_tags[] = {
>     { AV_CODEC_ID_ALAC,      0XFFFFFFFF },
> -    { AV_CODEC_ID_EAC3,      0XFFFFFFFF },
>     { AV_CODEC_ID_MLP,       0xFFFFFFFF },
>     { AV_CODEC_ID_OPUS,      0xFFFFFFFF },
>     { AV_CODEC_ID_PCM_S16BE, 0xFFFFFFFF },
> @@ -2754,8 +2753,6 @@ static const AVCodecTag additional_video_tags[] = {
>     { AV_CODEC_ID_RV10,      0xFFFFFFFF },
>     { AV_CODEC_ID_RV20,      0xFFFFFFFF },
>     { AV_CODEC_ID_RV30,      0xFFFFFFFF },
> -    { AV_CODEC_ID_RV40,      0xFFFFFFFF },
> -    { AV_CODEC_ID_VP9,       0xFFFFFFFF },

I cannot test atm but this patch does not look ok to me.

Carl Eugen