[FFmpeg-devel] [PATCH, RFC 2/2] lavc/vaapi_decode: find exact va_profile for HEVC_REXT

[Michael Niedermayer]

On Wed, Apr 03, 2019 at 12:10:22PM +0800, Linjie Fu wrote:
> Use the profile constraint flags to determine the exact va_profile for
> HEVC_REXT.
> 
> Directly cast PTLCommon to H265RawProfileTierLevel, and use ff_h265_get_profile
> to get the exact profile.
> 
> Signed-off-by: Linjie Fu <linjie.fu at intel.com>
> ---
> [v2]: use constraint flags to determine the exact profile, expose the
> codec-specific stuff at the beginning.
> [RFC]: is it acceptable to cast PTLCommon to H265RawProfileTierLevel for
> convenience? The members in PTLCommon should be strictly matched in
> H265RawProfileTierLevel.
> 
>  libavcodec/vaapi_decode.c | 74 +++++++++++++++++++++++++++++++--------
>  1 file changed, 59 insertions(+), 15 deletions(-)

breaks build:

CC	libavcodec/vaapi_decode.o
libavcodec/vaapi_decode.c: In function ‘vaapi_decode_find_exact_profile’:
libavcodec/vaapi_decode.c:421:16: error: ‘VAProfileHEVCMain422_10’ undeclared (first use in this function)
         return VAProfileHEVCMain422_10;
                ^
libavcodec/vaapi_decode.c:421:16: note: each undeclared identifier is reported only once for each function it appears in
libavcodec/vaapi_decode.c:423:16: error: ‘VAProfileHEVCMain444’ undeclared (first use in this function)
         return VAProfileHEVCMain444;
                ^
libavcodec/vaapi_decode.c:425:16: error: ‘VAProfileHEVCMain444_10’ undeclared (first use in this function)
         return VAProfileHEVCMain444_10;
                ^
libavcodec/vaapi_decode.c: At top level:
libavcodec/vaapi_decode.c:409:18: warning: ‘vaapi_decode_find_exact_profile’ defined but not used [-Wunused-function]
 static VAProfile vaapi_decode_find_exact_profile(AVCodecContext *avctx)
                  ^
make: *** [libavcodec/vaapi_decode.o] Error 1
make: Target `all' not remade because of errors.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190404/3c582aa4/attachment.sig>