[FFmpeg-devel] [PATCH] avcodec/frame_thread_encoder: factorize frame threading

[Marton Balint]

On Sun, 7 Apr 2019, James Almer wrote:

> On 4/7/2019 3:47 PM, Marton Balint wrote:
>> framethread.c is put into libavutil, but is has to be included directly to
>> avoid creating avpriv functions.
>
> If the reason behind this factorization is sharing the code between
> modules across several libraries and the function signatures are
> unlikely to change, then using avpriv_ functions is justified.
> The structs will be internal to libavutil, so the only thing tied to the
> ABI will be the avpriv symbols.
>
> Including the entire c file will result in unnecessary binary bloat once
> this code is used for example in libavfilter.

Yeah, I agree. I just did not want to make it avpriv until we have at 
least a second component using it, because I cannot forsee if the API 
will be sufficent or not.

Regards,
Marton