[FFmpeg-devel] [PATCH v5] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

Carl Eugen Hoyos ceffmpeg at gmail.com
Tue Apr 9 17:31:37 EEST 2019


2019-04-09 16:19 GMT+02:00, Shivam Goyal <shivgo at iitk.ac.in>:
> lavf/flv: Add XV (Xunlei Video) Support.
>
> Fixes ticket #3720
>
> I have fixed the minor mistakes in the patch. I have also
> checked the patch with patcheck.

> +    offset = ((avio_r8(ic) + rot & 0xff) << 24 |
> +                (avio_r8(ic) + rot & 0xff) << 16 |
> +                (avio_r8(ic) + rot & 0xff) << 8 |
> +                (avio_r8(ic) + rot & 0xff)) + 0x200000;

Should still be:
    offset = ((avio_r8(ic) + rot & 0xff) << 24 |
              (avio_r8(ic) + rot & 0xff) << 16 |
              (avio_r8(ic) + rot & 0xff) <<  8 |
              (avio_r8(ic) + rot & 0xff)) + 0x200000;
There is no 8/12-char indentation, only vertical alignment.

Please bump libavformat minor version.

Carl Eugen


More information about the ffmpeg-devel mailing list