[FFmpeg-devel] [PATCH v4 4/7] vf_misc_vaapi: Add missing return value checks
Mark Thompson
sw at jkqxz.net
Wed Apr 10 01:07:27 EEST 2019
Parameter buffer creation can fail.
---
libavfilter/vf_misc_vaapi.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/libavfilter/vf_misc_vaapi.c b/libavfilter/vf_misc_vaapi.c
index 6f31a04293..6fbd453741 100644
--- a/libavfilter/vf_misc_vaapi.c
+++ b/libavfilter/vf_misc_vaapi.c
@@ -84,10 +84,9 @@ static int denoise_vaapi_build_filter_params(AVFilterContext *avctx)
denoise.value = map(ctx->denoise, DENOISE_MIN, DENOISE_MAX,
caps.range.min_value,
caps.range.max_value);
- ff_vaapi_vpp_make_param_buffers(avctx, VAProcFilterParameterBufferType,
- &denoise, sizeof(denoise), 1);
-
- return 0;
+ return ff_vaapi_vpp_make_param_buffers(avctx,
+ VAProcFilterParameterBufferType,
+ &denoise, sizeof(denoise), 1);
}
static int sharpness_vaapi_build_filter_params(AVFilterContext *avctx)
@@ -116,11 +115,9 @@ static int sharpness_vaapi_build_filter_params(AVFilterContext *avctx)
SHARPNESS_MIN, SHARPNESS_MAX,
caps.range.min_value,
caps.range.max_value);
- ff_vaapi_vpp_make_param_buffers(avctx,
- VAProcFilterParameterBufferType,
- &sharpness, sizeof(sharpness), 1);
-
- return 0;
+ return ff_vaapi_vpp_make_param_buffers(avctx,
+ VAProcFilterParameterBufferType,
+ &sharpness, sizeof(sharpness), 1);
}
static int misc_vaapi_filter_frame(AVFilterLink *inlink, AVFrame *input_frame)
--
2.20.1
More information about the ffmpeg-devel
mailing list