[FFmpeg-devel] [PATCH V1] avformat/avformat.h: correct the comment for AVInputFormat.extensions

[Michael Niedermayer]

On Sat, Apr 13, 2019 at 08:46:06AM +0800, Jun Zhao wrote:
> From: Jun Zhao <barryjzhao at tencent.com>
> 
> Now the probe logic is: Only read_probe is NULL and extensions are defined,
> then no probe is done. Correct the comment to follow the coding logic.
> 
> Signed-off-by: Jun Zhao <barryjzhao at tencent.com>
> ---
>  libavformat/avformat.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavformat/avformat.h b/libavformat/avformat.h
> index 734ae54..bbfa61d 100644
> --- a/libavformat/avformat.h
> +++ b/libavformat/avformat.h
> @@ -659,8 +659,8 @@ typedef struct AVInputFormat {
>      int flags;
>  
>      /**
> -     * If extensions are defined, then no probe is done. You should
> -     * usually not use extension format guessing because it is not

> +     * If read_probe is NULL and extensions are defined, then no probe is done.

Why do you refer to extensions here ?
if read_probe is not set (NULL), no probe (based on input content) can be done,
extensions does not change that.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190414/acb03f78/attachment.sig>