[FFmpeg-devel] [PATCH V1 2/2] lavf: bump version/add Changelog entry when cleanup applehttp

[Carl Eugen Hoyos]

2019-04-16 11:32 GMT+02:00, Hendrik Leppkes <h.leppkes at gmail.com>:
> On Tue, Apr 16, 2019 at 10:58 AM Carl Eugen Hoyos <ceffmpeg at gmail.com>
> wrote:
>>
>> 2019-04-16 10:52 GMT+02:00, mypopy at gmail.com <mypopy at gmail.com>:
>> > On Tue, Apr 16, 2019 at 4:42 PM Hendrik Leppkes <h.leppkes at gmail.com>
>> > wrote:
>> >>
>> >> On Tue, Apr 16, 2019 at 7:57 AM Jun Zhao <mypopydev at gmail.com> wrote:
>> >> >
>> >> > From: Jun Zhao <barryjzhao at tencent.com>
>> >> >
>> >> > commit abfeba9 "lavf/hls: Cleanup the applehttp" missed
>> >> > the version bump and Changelog entry.
>> >> >
>> >> > Signed-off-by: Jun Zhao <barryjzhao at tencent.com>
>> >> > ---
>> >> >  Changelog             |    1 +
>> >> >  libavformat/version.h |    2 +-
>> >> >  2 files changed, 2 insertions(+), 1 deletions(-)
>> >> >
>> >> > diff --git a/Changelog b/Changelog
>> >> > index 5b2b1e5..2930471 100644
>> >> > --- a/Changelog
>> >> > +++ b/Changelog
>> >> > @@ -24,6 +24,7 @@ version <next>:
>> >> >  - KUX demuxer
>> >> >  - AV1 frame split bitstream filter
>> >> >  - lscr decoder
>> >> > +- cleanup applehttp in hls demuxer
>> >> >
>> >>
>> >> If you read the other changelog entries, does this seem like matching
>> >> the pattern in there? :)
>> >> ChangeLog is for end-users, for changes that developers should care
>> >> about, there is APIchanges.
>>
>> Without a version bump?
>>
>
> Well thats no reason to put it into ChangeLog regardless, because it
> just doesn't belong in there.
> This is runtime API, not compile-time API anyway, so someone needing
> this string for some reason and wanting to support all versions will
> have to check both strings regardless of version information,

All true!

Carl Eugen