[FFmpeg-devel] [PATCH]lavfi/fspp: Add a cast to silence a clang warning

[Carl Eugen Hoyos]

2019-04-18 14:07 GMT+02:00, Carl Eugen Hoyos <ceffmpeg at gmail.com>:
> 2019-04-18 12:16 GMT+02:00, Michael Niedermayer <michael at niedermayer.cc>:

>>> Silences a warning with clang:
>>> warning: implicit conversion from 'int' to 'int16_t' (aka 'short')
>>> changes
>>> value from 44130 to -21406
>>> ---
>>>  libavfilter/vf_fspp.h |    2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/libavfilter/vf_fspp.h b/libavfilter/vf_fspp.h
>>> index 802db14..bdafe8e 100644
>>> --- a/libavfilter/vf_fspp.h
>>> +++ b/libavfilter/vf_fspp.h
>>> @@ -31,7 +31,7 @@
>>>  #define DCTSIZE 8
>>>  #define DCTSIZE_S "8"
>>>
>>> -#define FIX(x,s)  ((int) ((x) * (1 << s) + 0.5) & 0xffff)
>>> +#define FIX(x,s)  ((int16_t)((x) * (1 << s) + 0.5))
>>
>> does it need the cast at all to avoid the warning ?
>
> Attached patch also avoids the warning.

Patch applied.

Thank you, Carl Eugen