[FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

Nicolas George george at nsup.org
Thu Apr 25 20:54:35 EEST 2019


Hendrik Leppkes (12019-04-25):
> The point of this kind of filtering is not that they are necessary to
> perform filtering, because you can filter at any sample rate, but that
> oversampling for certain filters, and downsampling after, improves
> quality. As such, negotiation is not really equipped to handle it,
> since its designed to deal with compatibility between filters, not
> quality concerns, and you also wouldn't want to remove the ability to
> filter at ordinary sample rates either.

I do not want them to be available ONLY with negotiation. If people want
to add them, fine.

But when negotiation decides a conversion needs to happen somewhere,
these treatments must be available for it, at the place where it is
needed, which is often not known to the user.

And the simplest way of achieving that is to make it an option of the
resample filter, or even better, en option if lswr. After all, it is
only the audio equivalent of sws_flags=neighbor.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190425/5a0af47b/attachment.sig>


More information about the ffmpeg-devel mailing list