[FFmpeg-devel] [PATCH] avfilter: add bilateral filter

[Moritz Barsnick]

Hi Paul,

On Sun, Apr 28, 2019 at 16:42:45 +0200, Paul B Mahol wrote:

Cosmetic nits:

> +Alowed range is from 1 to 6.
   ^ Allowed

> +Alowed range is from 2 to 256.
   ^
Ditto.

> +    float *bbufers[256];
              ^
I'm not sure of the intent, but would this be "buffers" or "bbuffers"?
> +static float lut_lookup(const float *lut, const int val1, const int val2)
> +{
> +    return lut[val1 > val2 ? val1 - val2 : val2 - val1];

FFABS() may help for readability.

I can't judge on the rest, as always.

Cheers,
Moritz