[FFmpeg-devel] [PATCH] lavfi/zmq: Avoid mem copy past the end of input buffer

[Paul B Mahol]

On Tue, Jul 30, 2019 at 11:24 PM Andriy Gelman <andriy.gelman at gmail.com>
wrote:

> From: Andriy Gelman <andriy.gelman at gmail.com>
>
> ---
>  libavfilter/f_zmq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavfilter/f_zmq.c b/libavfilter/f_zmq.c
> index 89da5bef06..744c721305 100644
> --- a/libavfilter/f_zmq.c
> +++ b/libavfilter/f_zmq.c
> @@ -139,7 +139,7 @@ static int recv_msg(AVFilterContext *ctx, char **buf,
> int *buf_size)
>          ret = AVERROR(ENOMEM);
>          goto end;
>      }
> -    memcpy(*buf, zmq_msg_data(&msg), *buf_size);
> +    memcpy(*buf, zmq_msg_data(&msg), *buf_size - 1);
>      (*buf)[*buf_size-1] = 0;
>
>  end:
> --
> 2.22.0
>

LGTM, I can not apply it, so I kindly ask other committers to apply it.