[FFmpeg-devel] [PATCH 2/3] avformat/assenc: optimize writing dialogs

[Paul B Mahol]

On Mon, Aug 5, 2019 at 11:35 PM Marton Balint <cus at passwd.hu> wrote:

> An example where the preivously added API can be useful.
>
> Also fixes ticket #6390.
>
> Signed-off-by: Marton Balint <cus at passwd.hu>
> ---
>  libavformat/assenc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/assenc.c b/libavformat/assenc.c
> index d50f18feb1..12aadca171 100644
> --- a/libavformat/assenc.c
> +++ b/libavformat/assenc.c
> @@ -95,7 +95,7 @@ static void purge_dialogues(AVFormatContext *s, int
> force)
>                     ass->expected_readorder, dialogue->readorder);
>              ass->expected_readorder = dialogue->readorder;
>          }
> -        avio_printf(s->pb, "Dialogue: %s\r\n", dialogue->line);
> +        avio_print(s->pb, "Dialogue: ", dialogue->line, "\r\n");
>          if (dialogue == ass->last_added_dialogue)
>              ass->last_added_dialogue = next;
>          av_freep(&dialogue->line);
> --
> 2.16.4
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


Whole patch set looks fine to me, but perhaps you want additional reviews.