[FFmpeg-devel] [PATCH v3 4/6] avformat/wavdec: s337m support

Gaullier Nicolas nicolas.gaullier at arkena.com
Thu Aug 8 16:22:29 EEST 2019


>.. this won't compile if S377m is disabled. Just go with the old #if
>solution, sorry for causing confusion
My mistake but I think it is a good idea to get rid of some bulky #if... Do you think a mixed usage of if and #if would be acceptable ? I think the following would be the best :
    if (!CONFIG_S337M_DEMUXER || st->codecpar->codec_id != AV_CODEC_ID_DOLBY_E) {
(...)
#if CONFIG_S337M_DEMUXER
    } else {
(... using s337m_get_packet method ... )
#endif
    }

NB: I have to rework all the patchset with carl's feedback, but this point will still remain, so better to have it solved now.

Thank you
Nicolas


More information about the ffmpeg-devel mailing list