[FFmpeg-devel] [PATCH v1] lavf/dump: add the valid check for consistent

[Limin Wang]

On Sat, Aug 10, 2019 at 05:14:18PM +0200, Carl Eugen Hoyos wrote:
> Am Sa., 10. Aug. 2019 um 16:59 Uhr schrieb <lance.lmwang at gmail.com>:
> >
> > From: Limin Wang <lance.lmwang at gmail.com>
> >
> > Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> > ---
> >  libavformat/dump.c | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/libavformat/dump.c b/libavformat/dump.c
> > index 1c44656..d3c0299 100644
> > --- a/libavformat/dump.c
> > +++ b/libavformat/dump.c
> > @@ -328,6 +328,11 @@ static void dump_cpb(void *ctx, AVPacketSideData *sd)
> >
> >  static void dump_mastering_display_metadata(void *ctx, AVPacketSideData* sd) {
> >      AVMasteringDisplayMetadata* metadata = (AVMasteringDisplayMetadata*)sd->data;
> > +
> > +    if (sd->size < sizeof(*metadata)) {
> > +        av_log(ctx, AV_LOG_INFO, "invalid data");
> 
> Why is this AV_LOG_INFO and not WARNING or ERROR?
It's for keep the style consistent. In the dump.c, all such error is
used as AV_LOG_INFO. If need, I'll submit a patch to change INFO to ERROR first? 


> 
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".