[FFmpeg-devel] [PATCH] ffplay: properly detect all window size changes

Paul B Mahol onemda at gmail.com
Wed Aug 14 18:33:14 EEST 2019


LGTM

On Tue, Aug 13, 2019 at 11:20 PM Marton Balint <cus at passwd.hu> wrote:

> SDL_WINDOWEVENT_SIZE_CHANGED should be used instead of
> SDL_WINDOWEVENT_RESIZED
> because SDL_WINDOWEVENT_RESIZED is only emitted if the resize happened due
> to
> an external event.
>
> Fixes ticket #8072.
>
> Additional references:
> https://bugzilla.libsdl.org/show_bug.cgi?id=4760
> https://wiki.libsdl.org/SDL_WindowEventID
>
> Signed-off-by: Marton Balint <cus at passwd.hu>
> ---
>  fftools/ffplay.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fftools/ffplay.c b/fftools/ffplay.c
> index 8fb8faeb06..fee0619f7c 100644
> --- a/fftools/ffplay.c
> +++ b/fftools/ffplay.c
> @@ -3436,7 +3436,7 @@ static void event_loop(VideoState *cur_stream)
>              break;
>          case SDL_WINDOWEVENT:
>              switch (event.window.event) {
> -                case SDL_WINDOWEVENT_RESIZED:
> +                case SDL_WINDOWEVENT_SIZE_CHANGED:
>                      screen_width  = cur_stream->width  =
> event.window.data1;
>                      screen_height = cur_stream->height =
> event.window.data2;
>                      if (cur_stream->vis_texture) {
> --
> 2.16.4
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list