[FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50

[Tomas Härdin]

tor 2019-08-15 klockan 13:55 +0200 skrev Thomas Mundt:
> Am Do., 15. Aug. 2019 um 11:01 Uhr schrieb Tomas Härdin <tjoppen at acc.umu.se
> > :
> > ons 2019-08-14 klockan 22:18 +0200 skrev Thomas Mundt:
> > > Hi Tomas,
> > > 
> > > Am Mi., 14. Aug. 2019 um 12:42 Uhr schrieb Tomas Härdin <
> > tjoppen at acc.umu.se
> > > > :
> > > > tis 2019-08-13 klockan 22:03 +0200 skrev Thomas Mundt:
> > > > > Hi,
> > > > > 
> > > > > attached patch fixes ticket #8077.
> > > > > Please comment.
> > > > 
> > > > Probably OK, bitrates lower than 50000000 are fine in D-10 according to
> > > > S356m.
> > > > 
> > > > > } else if ((sc->video_bit_rate >= 49999840) && (sc->video_bit_rate <=
> > > > > 50000000) && (mxf->time_base.den != 25)) {
> > > > 
> > > > You could drop the extra parentheses, else it should be fine.
> > > > 
> > > 
> > > New patch attached.
> > 
> > Looks OK. I'll push in a few days if no one else has any comments
> > 
> 
> Thanks. Would you mind porting it to branches 4.1 and 4.2?

I'm not quite sure what the process is for that. I have confirmed that
the problem exists in 4.1 and 4.2 and that your patch fixes it.

I think we also might want to put a note somewhere in the documentation
how to make NTSC IMX50 files.

/Tomas