[FFmpeg-devel] [PATCH]lavc/g729dec: Support decoding ACELP.KELVIN

[Paul B Mahol]

On Wed, Aug 21, 2019 at 11:12 AM Carl Eugen Hoyos <ceffmpeg at gmail.com>
wrote:

> Am Mi., 21. Aug. 2019 um 10:54 Uhr schrieb Paul B Mahol <onemda at gmail.com
> >:
> >
> > On Wed, Aug 21, 2019 at 10:44 AM Carl Eugen Hoyos <ceffmpeg at gmail.com>
> > wrote:
> >
> > > Am Mi., 21. Aug. 2019 um 10:40 Uhr schrieb Paul B Mahol <
> onemda at gmail.com
> > > >
> > > > The configure line is not needed. Where is Makefile change?
> > >
> > > This line makes no sense.
> >
> > Nope, you do not make sense.
>
> I hope you agree it is difficult to "make sense" in an answer to
> something that makes no sense.
>

Please consult doctors.


>
> > Configure line is completely bollocks.
>
> Works fine here.
>

Remove it, its is not relevant.


>
> > Makefile change is mandatory and in your case it is missing completely.
>
> Mandatory?
> I seem to remember a time when I tried to keep the whole magic in the
> Makefiles. Somebody said "no, the maintenance burden is too high,
> we do some of the magic in configure and some in the Makefile to make
> our lifes easier". What is it now? Should we move all the changes back
> in the Makefiles?
>

Are you trolling now? libavcodec/Makefile change is missing.

Also you need to use #ifdef for decoders in g729 file as user may enable
only one of decoders at time.


>
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".