[FFmpeg-devel] [PATCH 4/3 v2][RFC] avcodec/qtrle: call ff_reget_buffer() only when the picture data is going to change

[Michael Niedermayer]

On Mon, Aug 26, 2019 at 04:02:14PM -0300, James Almer wrote:
> ff_reget_buffer() will attempt to create a writable copy of the frame,
> which is not needed when the decoder intends to return a reference to
> the same buffer as the previous frame.
> 
> Should reduce data copy, hopefully achieving a similar speed up as
> a9dacdeea6168787a142209bd19fdd74aefc9dd6 without dropping frames.
> 
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
> Now ensuring there's a previous frame available to reuse.
> 
>  libavcodec/qtrle.c | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)

would a function like ff_reget_buffer() but that returns a read only frame
simplify this ?

Such function could then later also set any flag or UID

either way patch LGTM

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Never trust a computer, one day, it may think you are the virus. -- Compn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190827/e66dc5f5/attachment.sig>