[FFmpeg-devel] [PATCH V3 2/2] lavf/libsrt: enable other encryption parameters

[Limin Wang]

On Wed, Dec 04, 2019 at 10:46:44AM +0100, Moritz Barsnick wrote:
> On Wed, Dec 04, 2019 at 10:20:00 +0800, mypopy at gmail.com wrote:
> > > > +    { "enforced_encryption",      "Enforces that both connection parties have the same passphrase set ", OFFSET(enforced_encryption),        AV_OPT_TYPE_INT,      { .i64 = -1 }, -1, 1,         .flags = D|E },
> > >
> > > is this intended to be INT and not AV_OPT_TYPE_BOOL ?
> >
> > Now -1 means auto (default value depend on libsrt library itself) ,
> > this is the reason don't use the AV_OPT_TYPE_BOOL same as other srt
> > option in FFmpeg.
> 
> AV_OPT_TYPE_BOOL accepts -1 as a default.

Yes, I recall I have sumit a patch to change several flag to BOOL and haven't anybody review yet.
I have tested -1 is accetable as default, please confirm it and review my old pending patch also.

https://patchwork.ffmpeg.org/patch/15183/



> 
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".