[FFmpeg-devel] [PATCH v7 2/3] lavf/isom: support for demuxing and remuxing of MPEG-H 3D Audio in MP4

[Tsuchiya, Yuki (SHES)]

Hi James,

On 2019/12/12 21:45, "ffmpeg-devel on behalf of James Almer" <ffmpeg-devel-bounces at ffmpeg.org on behalf of jamrial at gmail.com> wrote:

    >> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
    >> index dd144ae20a..8456bfac6d 100644
    >> --- a/libavformat/movenc.c
    >> +++ b/libavformat/movenc.c
    >> @@ -2493,6 +2493,7 @@ static int mov_write_stbl_tag(AVFormatContext *s, AVIOContext *pb, MOVMuxContext
    >>      mov_write_stts_tag(pb, track);
    >>      if ((track->par->codec_type == AVMEDIA_TYPE_VIDEO ||
    >>           track->par->codec_id == AV_CODEC_ID_TRUEHD ||
    >> +         track->par->codec_id == AV_CODEC_ID_MPEGH_3D_AUDIO ||
    >
    > This still depends on packets being flagged as key. One would hope they
    > were correctly flagged by a parser or demuxer, but there's always a risk
    > they were not, so if it's possible to do some basic parsing of the
    > bitstream to look for a sync code or similar, that would be ideal. See
    > the custom mov_parse_vc1_frame() and mov_parse_truehd_frame() functions
    > used for this purpose for an example.
    >
    > If not possible, then this patch should be ok as is.
    
OK. I will contribute the bitstream(mhas) parser like mov_parse_mhas_frame() for adding sync frame information as separate patch.
In this patch, please proceed as is.