[FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP9 temporal scalability encoding option

[Wonkap Jang]

Thank you Michael,

I'll send out a new patch along with the other fix that is dependent on
this one.

Let's review there.

Thank you,

Wonkap


On Tue, Dec 17, 2019 at 11:21 AM Michael Niedermayer <michael at niedermayer.cc>
wrote:

> On Mon, Dec 16, 2019 at 02:23:00PM -0800, Wonkap Jang wrote:
> > This commit reuses the configuration options for VP8 that enables
> > temporal scalability for VP9. It also adds a way to enable three
> > preset temporal structures (refer to the documentation for more
> > detail) that can be used in offline encoding.
> > ---
> >  libavcodec/libvpxenc.c | 237 +++++++++++++++++++++++++++++++++++++----
> >  1 file changed, 219 insertions(+), 18 deletions(-)
>
> breaks build here
>
> CC      libavcodec/libvpxenc.o
> libavcodec/libvpxenc.c: In function ‘vpx_init’:
> libavcodec/libvpxenc.c:945:9: warning: passing argument 3 of
> ‘codecctl_intp’ from incompatible pointer type [enabled by default]
>          codecctl_intp(avctx, VP9E_SET_SVC_PARAMETERS, &svc_params);
>          ^
> libavcodec/libvpxenc.c:328:34: note: expected ‘int *’ but argument is of
> type ‘struct vpx_svc_extra_cfg_t *’
>  static av_cold int codecctl_intp(AVCodecContext *avctx,
>                                   ^
> libavcodec/libvpxenc.c: In function ‘vpx_encode’:
> libavcodec/libvpxenc.c:1563:17: error: ‘vpx_svc_layer_id_t’ has no member
> named ‘temporal_layer_id_per_spatial’
>          layer_id.temporal_layer_id_per_spatial[0] =
> layer_id.temporal_layer_id;
>                  ^
> libavcodec/libvpxenc.c:1573:13: warning: passing argument 3 of
> ‘codecctl_intp’ from incompatible pointer type [enabled by default]
>              codecctl_intp(avctx, VP9E_SET_SVC_LAYER_ID, &layer_id);
>              ^
> libavcodec/libvpxenc.c:328:34: note: expected ‘int *’ but argument is of
> type ‘struct vpx_svc_layer_id_t *’
>  static av_cold int codecctl_intp(AVCodecContext *avctx,
>                                   ^
> make: *** [libavcodec/libvpxenc.o] Error 1
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> During times of universal deceit, telling the truth becomes a
> revolutionary act. -- George Orwell
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".