[FFmpeg-devel] [PATCH] avfilter: add thistogram video filter

[Nicolas George]

Paul B Mahol (12019-12-26):
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  doc/filters.texi            |  46 +++++
>  libavfilter/Makefile        |   1 +
>  libavfilter/allfilters.c    |   1 +
>  libavfilter/vf_thistogram.c | 358 ++++++++++++++++++++++++++++++++++++
>  4 files changed, 406 insertions(+)
>  create mode 100644 libavfilter/vf_thistogram.c
> 
> diff --git a/doc/filters.texi b/doc/filters.texi
> index 8c5d3a5760..4468351fc4 100644
> --- a/doc/filters.texi
> +++ b/doc/filters.texi
> @@ -11674,6 +11674,7 @@ the histogram. Possible values are @code{none}, @code{weak} or
>  @code{strong}. It defaults to @code{none}.
>  @end table
>  
> + at anchor{histogram}
>  @section histogram
>  
>  Compute and draw a color distribution histogram for the input video.
> @@ -17717,6 +17718,51 @@ PAL output (25i):
>  16p: 33333334
>  @end example
>  
> + at section thistogram
> +
> +Compute and draw a color distribution histogram for the input video across time.
> +
> +Unlike @ref{histogram} video filter which only shows histogram of single input frame
> +at certain time, this filter shows also past histograms of number of frames defined
> +by @code{width} option.

Is there a reason to make it a separate filter rather than adding the
option "width" to the existing filter?

If it cannot be done, query_formats(), config_input() and a significant
part of filter_frame() are identical or almost identical: please reduce
code duplication.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191226/4969d2f8/attachment.sig>