[FFmpeg-devel] [PATCH 2/4 v2] avcodec/libx265: add a qp option and apply the relevant global AVCodecContext settings to the encoder context

[Derek Buitenhuis]

On 30/12/2019 19:20, James Almer wrote:
> +        snprintf(cqp, sizeof(cqp), "%d", ctx->cqp);
> +        if (ctx->api->param_parse(ctx->params, "qp", cqp) == X265_PARAM_BAD_VALUE) {
> +            av_log(avctx, AV_LOG_ERROR, "Invalid cqp: %d.\n", ctx->cqp);
> +            return AVERROR(EINVAL);
> +        }

Is the reason this doesn't use parse_int so that this error message can be given?

Otherwise, LGTM.

- Derek