[FFmpeg-devel] [PATCH] avformat/movenc: Add more error checking when writing sample entries.

[Michael Niedermayer]

On Tue, Feb 05, 2019 at 10:42:32AM -0800, Baptiste Coudurier wrote:
> Hi Niki,
> 
> 
> > On Feb 4, 2019, at 6:03 PM, Niki Bowe <nbowe at google.com> wrote:
> > 
> > Hi Baptiste. 
> > I agree. This patch does cause it to fail in mov_write_header in the given example, by propagating the errors returned from mov_write_ac3_tag.
> > 
> > It is not always extradata related.
> > Eg EAC3 parses the packets during muxing to build the dec3 atom. Perhaps this should be made extradata, but its not today.
> > A definitely not extradata related example: mov_write_tmcd_tag can fail for fps reasons.
> > Many atom writing functions can fail and return error codes, but today very little error checking exists.
> 
> Ok, patch looks good to me.

will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The smallest minority on earth is the individual. Those who deny 
individual rights cannot claim to be defenders of minorities. - Ayn Rand
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190207/bee6b39c/attachment.sig>