[FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

[Michael Niedermayer]

On Fri, Feb 15, 2019 at 11:17:38PM +0100, Mathieu Duponchelle wrote:
> On 2/14/19 10:01 PM, Michael Niedermayer wrote:
> > if someone checks it against some spec and or tests it against some
> > decoders, probably yes,
> 
> The relevant part of the spec is section 6.2.3 in
> <http://www.atsc.org/wp-content/uploads/2015/03/a_53-Part-4-2009.pdf>,
> and I have indeed tested this patch against FFmpeg's mpeg2video decoder,
> it seems to work just fine :)

It would be better to test against a decoder from a unrelated codebase
Otherwise its a bit like testing your new language skills by talking with
yourself.


> 
> Note that this commit is very similar in intent to
> e06114fed3afa69187b3dfc09a7a1a25cfd558b3 if that helps.
> 
> >  
> > also might be a good idea to bump the micro version of libavcodec
> 
> I'm not familiar with this procedure I must admit :)

you add 1 to the value after LIBAVCODEC_VERSION_MICRO
of course this could also be done by whoever commits this ...
just saying someone should when this is pushed

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190216/25b39840/attachment.sig>