[FFmpeg-devel] patch for failing on WavPack DSD files

[David Bryant]

On 1/6/19 4:43 AM, Carl Eugen Hoyos wrote:
> 2019-01-03 6:19 GMT+01:00, David Bryant <david at wavpack.com>:
>> On 12/28/18 3:56 AM, Paul B Mahol wrote:
>>> On 12/24/18, Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
>>>> On 24/12/2018 17:47, David Bryant wrote:
>>>>> I want to do that, but am swamped at work right now, so it will probably
>>>>> be a few months before I can get to that.
>>>>>
>>>>> In the meantime, I think this patch would be a safe stopgap (and prevent
>>>>> the Kodi crash).
>>>> I think it's OK for the meantime (my opinion).
>>> Applied.
>> The guys at Kodi asked me to request that this patch be backported to 4.0.
> While this may be ok, somebody should tell the Kodi developers
> to fix the crash as I would expect it's possible to create files
> that are still tried to be decoded but produce identical output
> as before.
>
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

I agree. In fact, take a WavPack DSD file and clear the bit that this patch checks for, and I'll bet you'll get exactly the old
behavior.

It should be investigated as to why Kodi crashes with these files while FFmpeg just spews a bunch of error messages.

-David