[FFmpeg-devel] [PATCH 4/6] avcodec/vp6: use ff_vp4_[hv]_loop_filter_12_c
Peter Ross
pross at xvid.org
Mon Jan 14 10:11:04 EET 2019
On Sun, Jan 13, 2019 at 09:39:57PM +0100, Carl Eugen Hoyos wrote:
> 2019-01-13 21:02 GMT+01:00, Peter Ross <pross at xvid.org>:
> > ---
> > libavcodec/vp56.c | 10 ++++++++++
> > libavcodec/vp56.h | 1 +
> > libavcodec/vp56dsp.c | 19 -------------------
> > 3 files changed, 11 insertions(+), 19 deletions(-)
> > + if (dx)
> > + ff_vp4_h_loop_filter_12_c(yuv + 10-dx, stride,
> > bounding_values);
> > + if (dy)
> > + ff_vp4_v_loop_filter_12_c(yuv + stride*(10-dy), stride,
> > bounding_values);
> > + }
> > }
>
> This is your code now but I wonder why it helps not to merge
> this with 1/6.
fair enough.
> > - s->edge_filter_hor = vp6_edge_filter_hor;
> > - s->edge_filter_ver = vp6_edge_filter_ver;
>
> And why are the new functions called "_c" but
> are not part of the context?
> (Or do I misread the code?)
i will drop the _c.
and for consisistency they probably should be ff_vp3dsp_xxx.
they are not part of the context, because they there are are no
asm alternative functions (yet). it seems like a waste creating
context function pointers that only every point to the one function.
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190114/130de28a/attachment.sig>
More information about the ffmpeg-devel
mailing list