[FFmpeg-devel] [PATCH V2 1/2] lavf/utils: fix error like "offset 0x1f85: partial file"

[Hendrik Leppkes]

On Mon, Jan 14, 2019 at 5:09 PM Jun Zhao <mypopydev at gmail.com> wrote:
>
> fix the issue like "offset 0x1f85: partial file" when demuxer mp4
> from http/https/crypto
>
> Signed-off-by: Jun Zhao <mypopydev at gmail.com>
> ---
>  libavformat/utils.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/libavformat/utils.c b/libavformat/utils.c
> index 7afef54..92a0eb7 100644
> --- a/libavformat/utils.c
> +++ b/libavformat/utils.c
> @@ -2103,7 +2103,8 @@ void ff_configure_buffers_for_index(AVFormatContext *s, int64_t time_tolerance)
>                 "optimally without knowing the protocol\n");
>      }
>
> -    if (proto && !(strcmp(proto, "file") && strcmp(proto, "pipe") && strcmp(proto, "cache")))
> +    if (proto && !(strcmp(proto, "file") && strcmp(proto, "pipe") && strcmp(proto, "cache") &&
> +                   strcmp(proto, "https") && strcmp(proto, "http") && strcmp(proto, "crypto")))
>          return;
>
>      for (ist1 = 0; ist1 < s->nb_streams; ist1++) {

Isn't the entire point of this function to do stuff for network
streams,  like http?
If there is a bug in there, it should probably be fixed, and not just disabled?

- Hendrik