[FFmpeg-devel] [PATCH]lavf/cafdec: Do not fail hard for files ending with junk

Carl Eugen Hoyos ceffmpeg at gmail.com
Tue Jan 15 13:55:02 EET 2019


2019-01-15 12:53 GMT+01:00, Paul B Mahol <onemda at gmail.com>:
> On 1/15/19, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>> 2019-01-15 10:23 GMT+01:00, Paul B Mahol <onemda at gmail.com>:
>>> On 1/15/19, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>
>>>> A user provided a real-life caf file ending with junk after the data
>>>> chunk, QuickTime reads such files.
>>>>
>>>> Please comment, Carl Eugen
>>>>
>>>
>>> NACK, there is data after junk bytes, which would get simply
>>> discarded with your patch.
>>
>> Please elaborate: I don't think any data gets discarded because
>> of this patch.
>
> I told you already, hex edit size of data chunk to very big number and
> play file again.

Of course.

But how does this change the output compared to my patch?

Carl Eugen


More information about the ffmpeg-devel mailing list