[FFmpeg-devel] [PATCH] avfilter/buffersrc: print relevant info when skipping filter reinit

[Carl Eugen Hoyos]

2019-01-25 14:02 GMT+01:00, Gyan <ffmpeg at gyani.pro>:
>
> On 25-01-2019 06:25 PM, Carl Eugen Hoyos wrote:
>> 2019-01-25 13:52 GMT+01:00, Gyan <ffmpeg at gyani.pro>:
>>>
>>> On 25-01-2019 06:11 PM, Carl Eugen Hoyos wrote:
>>>> 2019-01-25 13:35 GMT+01:00, Gyan <ffmpeg at gyani.pro>:
>>>>
>>>>> +        av_log(s, AV_LOG_WARNING, "Changing video frame
>>>>> properties on the fly is not supported by all filters.\n");\
>>>>
>>>> In which situations is this new warning shown?
>>>
>>> e.g.
>>>        -reinit_filter 0 -i ChangingResolutions.mp4 -vf somefilter  ...
>>
>> Is it only shown if the filter does not support re-initialization?
>>
> No. As the existing msgs indicate, it is always printed when
> _some_ frame properties have changed.

I may misunderstand but I believe that no warning should be
shown in this case.

> The new addition allows the user to discover which properties
> those are, with timestamp. They can then choose to continue,
> allow reinit or partition the input (if viable) as appropriate.

It appears to me that the only thing the message would do is
to confuse users that do not understand the warning (but see
above).

Maybe you could provide a more concrete example of when
this warning helps to help me understand the issue?

Carl Eugen