[FFmpeg-devel] [PATCH 3/5] avfilter/vf_super2xsai: fix big-endian writing

[Carl Eugen Hoyos]

2019-01-27 16:12 GMT+01:00, Muhammad Faiz <mfcc64 at gmail.com>:
> On Sun, Jan 27, 2019 at 9:17 PM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>
>> 2019-01-27 15:07 GMT+01:00, Muhammad Faiz <mfcc64 at gmail.com>:
>> > On Sun, Jan 27, 2019 at 7:19 PM Carl Eugen Hoyos <ceffmpeg at gmail.com>
>> > wrote:
>> >>
>> >> 2019-01-27 10:36 GMT+01:00, Muhammad Faiz <mfcc64 at gmail.com>:
>> >> > Fix mismatched checksum on fate-filter-pixfmts-super2xsai.
>> >>
>> >> I believe this patch and 2/5 are unrelated and should be
>> >> committed independently of the patchset.
>> >
>> > No. [2/5] and [3/5] depend on [1/5].
>>
>> No (at least afaiu).
>> The fate tests for these changes depend on the first patch.
>> But if the tests are currently broken, they cannot be used
>> as reasoning for anything.
>> Instead, the code should be fixed and the tests disabled.
>> (imo)
>
> Don't forget that 2/5 and 3/5 bugs (and p010/p016 bugs) are
> revealed by 1/5.

I know, I understood this.

> It means that 1/5 is important.

I neither said that it is important nor that it is unimportant.

I seems to me that this bug fix (for a bug that was thankfully
found by a patch written by you) is not related to the fate
system.
If fixing this bug means that fate breaks, it indicates that
fate is wrong and that maybe the fate test should be
disabled / replaced.

Carl Eugen