[FFmpeg-devel] [PATCH]lavc/zmbvenc: Do not left-shift negative values

Michael Niedermayer michael at niedermayer.cc
Mon Jul 1 21:30:07 EEST 2019


On Mon, Jul 01, 2019 at 01:47:46AM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch fixes the only (remaining) issue I see with the sample
> of ticket #7980.
> 
> Please comment, Carl Eugen

>  zmbvenc.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 39d38ac46b445460b0f27aec16e70ed176fa7cfe  0001-lavc-zmbvenc-Do-not-left-shift-negative-values.patch
> From e6ff8f43c0d92733335b52290e18231438ce7770 Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos <ceffmpeg at gmail.com>
> Date: Mon, 1 Jul 2019 01:45:36 +0200
> Subject: [PATCH] lavc/zmbvenc: Do not left-shift negative values.
> 
> Fixes the following ubsan errors with the sample from ticket #7980:
> libavcodec/zmbvenc.c:243:29: runtime error: left shift of negative value -4
> libavcodec/zmbvenc.c:244:28: runtime error: left shift of negative value -2
> ---
>  libavcodec/zmbvenc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

LGTM

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190701/3906aa49/attachment.sig>


More information about the ffmpeg-devel mailing list