[FFmpeg-devel] [PATCH] MIPS: replace addi with addiu

[Michael Niedermayer]

On Tue, Jul 09, 2019 at 09:10:33PM +0800, Shiyou Yin wrote:
> >-----Original Message-----
> >From: ffmpeg-devel-bounces at ffmpeg.org [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf Of
> >YunQiang Su
> >Sent: Tuesday, July 2, 2019 11:53 AM
> >To: ffmpeg-devel at ffmpeg.org
> >Cc: YunQiang Su
> >Subject: [FFmpeg-devel] [PATCH] MIPS: replace addi with addiu
> >
> >addi/daddi are deprecated by MIPS for years, and MIPS r6 remove
> >them.
> >
> >They should be replace with addiu:
> >   ADDIU performs the same arithmetic operation but
> >   does not trap on overflow.
> >---
> > libavcodec/mips/cabac.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/libavcodec/mips/cabac.h b/libavcodec/mips/cabac.h
> >index 82cee29..2a05e5a 100644
> >--- a/libavcodec/mips/cabac.h
> >+++ b/libavcodec/mips/cabac.h
> >@@ -72,7 +72,7 @@ static av_always_inline int get_cabac_inline(CABACContext *c,
> >
> >         "and          %[tmp0],       %[c_low],       %[cabac_mask] \n\t"
> >         "bnez         %[tmp0],       1f                            \n\t"
> >-        PTR_ADDI     "%[tmp0],       %[c_low],       -0X01         \n\t"
> >+        PTR_ADDIU    "%[tmp0],       %[c_low],       -0x01         \n\t"
> >         "xor          %[tmp0],       %[c_low],       %[tmp0]       \n\t"
> >         PTR_SRA      "%[tmp0],       %[tmp0],        0x0f          \n\t"
> >         PTR_ADDU     "%[tmp0],       %[tmp0],        %[tables]     \n\t"
> >--
> >2.20.1
> >
> 
> good suggestion.

will apply

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190710/89db10e3/attachment.sig>