[FFmpeg-devel] [PATCH] dump_extra: Don't add extradata if it already exists

[Michael Niedermayer]

On Sat, Jul 13, 2019 at 04:55:50AM +0200, Andreas Rheinhardt wrote:
> The dump_extra bitstream filter currently simply adds the extradata to
> the packets indicated by the user without checking whether said
> extradata already exists in the packets. Besides wasting space
> duplicated extradata in the same packet/access unit is also forbidden
> for some codecs, e.g. MPEG-2.
> 
> This check has been added to be able to use the mpeg2_qsv encoder (which
> only adds the sequence headers to the first packet) in broadcast
> scenarios where repeating sequence headers are required.
> 
> The check used here is not perfect: E.g. dump_extra would add the
> extradata to a H.264 access unit consisting of an access unit delimiter,
> SPS, PPS and slices.
> 
> Fixes #8007.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
>  doc/bitstream_filters.texi      | 4 +++-
>  libavcodec/dump_extradata_bsf.c | 4 +++-
>  2 files changed, 6 insertions(+), 2 deletions(-)

will apply

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190714/429906ec/attachment.sig>