[FFmpeg-devel] [PATCH] avcodec: add IMM5 decoder

Hendrik Leppkes h.leppkes at gmail.com
Tue Jul 16 16:40:31 EEST 2019


On Tue, Jul 16, 2019 at 3:26 PM James Almer <jamrial at gmail.com> wrote:
>
> > +    .priv_data_size = sizeof(IMM5Context),
> > +    .caps_internal  = FF_CODEC_CAP_INIT_THREADSAFE |
> > +                      FF_CODEC_CAP_INIT_CLEANUP,
>
> You could set DR1, and set both h264_avctx->get_buffer2 and
> hevc_avctx->get_buffer2 to avctx->get_buffer2, i think.
>

Not sure thats safe, since the caller would then get called on the
internal avctx, which might be rather unexpected.

If you really wanted to offer get_buffer2, there would probably need
to be a dummy call in  between that takes it from the internal avctx
and then re-calls get_buffer2 on the public avctx.

- Hendrik


More information about the ffmpeg-devel mailing list