[FFmpeg-devel] [PATCH] avformat/movenc: always write a colr atom

[James Almer]

On 7/16/2019 12:41 PM, Dave Rice wrote:
> Hi James,
> 
>> On Jul 16, 2019, at 9:47 AM, James Almer <jamrial at gmail.com> wrote:
>>
>> -    { "write_colr", "Write colr atom (Experimental, may be renamed or changed, do not use from scripts)", 0, AV_OPT_TYPE_CONST, {.i64 = FF_MOV_FLAG_WRITE_COLR}, INT_MIN, INT_MAX, AV_OPT_FLAG_ENCODING_PARAM, "movflags" },
> 
> The comment said specifically not to use this option in scripts; however, there were ffmpeg users (I admit myself as one) who wanted both to use scripts and write valid QuickTime files with colr data. I’d suggest permitting the option to remain but to change the default behavior from disabled to enabled. If I understand correctly, after this patch, encoding with `-movflags write_colr` would cause ffmpeg to fail with an error from the mov muxer.

Alright, I'll do that.

> 
> Dave
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>