[FFmpeg-devel] [PATCH 3/6] avcodec/ffwavesynth: use uint32_t to compute difference, it is enough

[Nicolas George]

Michael Niedermayer (12019-07-08):
> On Sat, Jun 22, 2019 at 01:29:33AM +0200, Michael Niedermayer wrote:
> > Fixes: signed integer overflow: 6494225984479297536 - -6043795377581187040 cannot be represented in type 'long'
> > Fixes: 15285/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5632780307791872
> > 
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavcodec/ffwavesynth.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> will apply

Sorry, I thought I missed the spot and you already applied it.

This patch could be merged with this one:

avcodec/ffwavesynth: More correct cast in wavesynth_seek()

but it is not very important.

As for:

avcodec/ffwavesynth: Fix backward lcg_seek()
avcodec/ffwavesynth: Simplify lcg_seek(), avoid negative case

If you checked they generate the same sequence, then ok and thanks. If
not, then I can do the testing tomorrow.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190719/41081437/attachment.sig>