[FFmpeg-devel] [PATCH 2/3] lavf/aviobuf: make AVSEEK_SIZE usable from outside.

[Hendrik Leppkes]

On Fri, Jul 19, 2019 at 11:49 PM Nicolas George <george at nsup.org> wrote:
>
> Michael Niedermayer (12019-07-19):
> > > +    if ((whence & AVSEEK_SIZE))
> > redundant ()
>
> I use it as a marker that it is not a mistake for &&. IIRC, gcc (with
> some options) warns about "if (a & b)" but accepts "if ((a & b))", and
> that is the preferred way. We already have a few instances in the code
> base, not all of them mine.
>

That seems like a particularly dumb compiler "feature". Checking
bitmasks for a set bit seems like a rather standard if condition.

- Hendril