[FFmpeg-devel] [PATCH 6/6] avcodec/flicvideo: More strictly check chunk size for FLI_COPY

[Paul B Mahol]

On 7/19/19, Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Fri, Jul 19, 2019 at 03:54:19PM +0200, Paul B Mahol wrote:
>> On 7/19/19, Michael Niedermayer <michael at niedermayer.cc> wrote:
>> > On Sat, Jun 22, 2019 at 01:29:36AM +0200, Michael Niedermayer wrote:
>> >> Fixes: Timeout (40sec -> 13sec)
>> >> Fixes:
>> >> 15417/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLIC_fuzzer-5679812615602176
>> >>
>> >> Found-by: continuous fuzzing process
>> >> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
>> >> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
>> >> ---
>> >>  libavcodec/flicvideo.c | 4 ++--
>> >>  1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > will apply
>> >
>>
>> Why? This actually is breaking old code.
>> Can you please stop committing such kind of patches?
>
> This patch was on the mailing list since a month, why do you point
> out a problem with it only once i say that i intend to apply it ?
>
> either way, ill of course not apply it now that you point to a
> problem. But please provide a testcase that this patch breaks

Apparently decoder have padding of some kind for this stuff.
So check FLIC video files with different resolutions (the one that are
not same as padded values).

>
> Thanks
>
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> "Nothing to hide" only works if the folks in power share the values of
> you and everyone you know entirely and always will -- Tom Scott
>
>