[FFmpeg-devel] [PATCH] libavfilter/vf_drawtext: Avoid undefined behavior from GET_UTF8

Aaron Boushley boushley at gmail.com
Sat Jul 27 17:14:51 EEST 2019


The vf_drawtext filter uses the GET_UTF8 macro in multiple locations.
Each of these use `continue;` as the error handler. However the
documentation for the GET_UTF8 macro states "ERROR should not contain
a loop control statement which could interact with the internal while
loop, and should force an exit from the macro code (e.g. through a
goto or a return) in order to prevent undefined results."

This patch adjusts vf_drawtext to use goto error handlers similar to
other locations in ffmpeg.

Aaron

PS Sorry for having to send again, sent from the wrong address last
time, so patchwork didn't pick it up.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libavfilter-drawtext-avoid-undefined-behavior.patch
Type: application/octet-stream
Size: 3262 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190727/918370ca/attachment.obj>


More information about the ffmpeg-devel mailing list