[FFmpeg-devel] [PATCH 3/4] avformat/wsddec: Fix undefined shift

Michael Niedermayer michael at niedermayer.cc
Sat Jun 8 12:28:00 EEST 2019


Fixes: left shift of 1 by 31 places cannot be represented in type 'int'
Fixes: 15123/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5738039235575808

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavformat/wsddec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/wsddec.c b/libavformat/wsddec.c
index dfa8014b1c..43660d4cea 100644
--- a/libavformat/wsddec.c
+++ b/libavformat/wsddec.c
@@ -137,7 +137,7 @@ static int wsd_read_header(AVFormatContext *s)
     if (!(channel_assign & 1)) {
         int i;
         for (i = 1; i < 32; i++)
-            if (channel_assign & (1 << i))
+            if (channel_assign & (1U << i))
                 st->codecpar->channel_layout |= wsd_to_av_channel_layoyt(s, i);
     }
 
-- 
2.21.0



More information about the ffmpeg-devel mailing list