[FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg: log skipped initial non-keyframes

[Michael Niedermayer]

On Fri, Jun 07, 2019 at 10:35:03PM +0200, Stephan Hilb wrote:
> >> -        !ost->copy_initial_nonkeyframes)
> >> +        !ost->copy_initial_nonkeyframes) {
> >> +        av_log(NULL, AV_LOG_DEBUG, "skipping initial
> >> non-keyframe\n"); return;  
> > 
> > Incorrect indentation.
> 
> It's actually the same indentation as in other places in the same file,
> what would be the correct way then?
> 
> > I suggest this message should be at INFO level, but appear only once.
> 
> I'm fine with INFO level. Repeated messages get supressed anyways, does
> that suffice?

Repeated messages only get supressed if there is no interspaced message
if 2 things generate a message per frame, neither will be supressed

[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

"You are 36 times more likely to die in a bathtub than at the hands of a
terrorist. Also, you are 2.5 times more likely to become a president and
2 times more likely to become an astronaut, than to die in a terrorist
attack." -- Thoughty2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190609/af96a5cf/attachment.sig>